test(NODE-5920): do not throw if the server returns unknown saslSupportedMechs #4299
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
added
the
Primary Review
dariakp
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Could we move this into a stand-alone prose file and make the context title match the spec prose test and include the spec steps in comments so that it follows the format of the rest of the prose tests? (The goal is easier auditability of spec tests - to know what prose we implemented and if the prose test later gets updated, which version of the test we implemented)
dariakp
requested changes
Nov 4, 2024
test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
Outdated
Show resolved
Hide resolved
dariakp
requested changes
Nov 6, 2024
dariakp
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Spec compliance
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript